Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes experimental_approximateDocumentStoreMiB #5629

Merged
merged 3 commits into from
Aug 19, 2021
Merged

Fixes experimental_approximateDocumentStoreMiB #5629

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e6bbd9
Sets experimental_approximateDocumentStoreMiB so it functions in init…
owenallenaz Aug 19, 2021
3ed241c
Makes prettier happy.
owenallenaz Aug 19, 2021
842d56f
CHANGELOG update
glasser Aug 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/apollo-server-core/src/ApolloServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,8 @@ export class ApolloServerBase<

this.parseOptions = parseOptions;
this.context = context;
this.experimental_approximateDocumentStoreMiB =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch! I would have thought that TS would give a noUnusedLocals error on the declaration of experimental_approximateDocumentStoreMiB but its existence affects the contents of requestOptions.

experimental_approximateDocumentStoreMiB;

// Allow tests to override process.env.NODE_ENV. As a bonus, this means
// we're only reading the env var once in the constructor, which is faster
Expand Down