Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Issue #5724: parse all content types ending with +json as json in rest data source #5737

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Resolve Issue #5724: parse all content types ending with +json as json in rest data source #5737

merged 2 commits into from
Sep 29, 2021

Conversation

nholik
Copy link
Contributor

@nholik nholik commented Sep 22, 2021

This commit addresses issue 5724. It is a simple change to treat all content types ending with +json similar to how all content types beginning with application/json are automatically parsed as JSON. The helps cover some other common types of JSON types beyond the original hard coded exception.

@apollo-cla
Copy link

@nholik: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@glasser glasser self-assigned this Sep 28, 2021
@glasser
Copy link
Member

glasser commented Sep 28, 2021

This looks good. It needs a CHANGELOG.md entry before it can be merged, which I can get to soon unless you do it first. (It's a little weird how we still have a single CHANGELOG.md file even though packages such as apollo-datasource-rest have unrelated versioning; I'd like to eventually move apollo-datasource-rest and apollo-datasource to its own repo as part of improving this.)

@glasser glasser enabled auto-merge (squash) September 29, 2021 00:23
nholik and others added 2 commits September 28, 2021 17:38
@glasser glasser merged commit e199acc into apollographql:main Sep 29, 2021
@nholik nholik deleted the augment-json-parsing-rest-data-source branch September 29, 2021 00:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants