Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove caching packages #6541

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

trevor-scheer
Copy link
Member

@trevor-scheer trevor-scheer commented Jun 8, 2022

Remove apollo-server-caching, apollo-server-cache-redis, and apollo-server-cache-memcached packages. We will continue to offer bugfixes for these packages as needed but don't intend to continue active development on them. Our recommendation going forward will be to use the keyv package along with our KeyvAdapter from the @apollo/utils.keyvadapter package. Docs updates to come in a following PR (but coupled with this release).

The KeyValueCache interface and InMemoryLRUCache wrapper around lru-cache (as well as a few useful cache wrappers like PrefixingKeyValueCache) will continue to exist in the @apollo/utils.keyvaluecache package. It's worth mentioning that InMemoryLRUCache is on a newer major version of lru-cache which doesn't permit the unbounded behavior which we've had by default. In AS 3.9 you can opt into the bounded cache, and in AS4 it will be the default.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 8, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3e2c0f9:

Sandbox Source
Apollo Server Typescript Configuration
Apollo Server Configuration

Copy link
Member

@glasser glasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps PR description should note that the contents of apollo-server-caching have migrated (roughly, with a change to boundedness of InMemory) to the utils package

@trevor-scheer trevor-scheer merged commit ed3a6df into release-3.9.0 Jun 8, 2022
@trevor-scheer trevor-scheer deleted the trevor/remove-as-caching-packages branch June 8, 2022 20:38
trevor-scheer added a commit that referenced this pull request Jun 15, 2022
Remove apollo-server-caching, apollo-server-cache-redis, and
apollo-server-cache-memcached packages. We will continue to offer bugfixes for
these packages as needed but don't intend to continue active development on
them. Our recommendation going forward will be to use the keyv package along
with our KeyvAdapter from the @apollo/utils.keyvadapter package. Docs updates to
come in a following PR (but coupled with this release).

The KeyValueCache interface and InMemoryLRUCache wrapper around lru-cache (as
well as a few useful cache wrappers like PrefixingKeyValueCache) will continue
to exist in the @apollo/utils.keyvaluecache package. It's worth mentioning that
InMemoryLRUCache is on a newer major version of lru-cache which doesn't permit
the unbounded behavior which we've had by default. In AS 3.9 you can opt into
the bounded cache, and in AS4 it will be the default.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants