Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sample in Azure function README.md #747

Merged
merged 4 commits into from
Mar 12, 2018

Conversation

donovamb
Copy link
Contributor

@donovamb donovamb commented Jan 4, 2018

The sample was missing a parameter in the calls to the apollo server. I also added a note about a current issue with local development of Azure functions on Macs.

Fixes #684 .

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

The sample was missing a parameter in the calls to the apollo server. I also added a note about a current issue with local development of Azure functions on Macs.
@apollo-cla
Copy link

@donovamb: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@abernix abernix merged commit 715ce7b into apollographql:master Mar 12, 2018
@abernix
Copy link
Member

abernix commented Mar 12, 2018

Merging this in to get the update for the schema in there, which is certainly relevant!

In regard to the macOS Warning: I've gone ahead and removed it right now since the issue you linked to has been closed. If that's still relevant, please open a new PR!

Thanks for opening this PR originally!

@stubailo stubailo mentioned this pull request Mar 12, 2018
4 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants