-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add federated tracing instrumentation #25
Merged
glasser
merged 17 commits into
apollographql:master
from
lennyburdette:federated-tracing
Sep 27, 2019
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ddd57a6
feat: add federated tracing instrumentation
8a2afe5
Use wildcard type instead of raw type
glasser c38658a
Remove unnecessary public from private class
glasser ca61630
Add schema fields used in test
glasser 6ee9983
Properly handle ordinary errors thrown from fetchers
glasser f86afba
Use ExecutionResultImpl.Builder to simplify code
glasser a59ee3c
"test" two Options methods so they are used outside the package
glasser 2d84590
Factor out instantToTimestamp
glasser 2bc9d9c
Add a bunch of `@NotNull` annotations
glasser ca0de0d
Fix nested lists in getParent (renamed to getParentNode)
glasser bcac8ae
fixup: attach parse and validation errors to the tracing root node
37d8dd3
Implement HTTP header sensitivity
glasser becdcb7
README
glasser f2db2d5
Revert getParentNode back to recursive (but keep the bug fix)
glasser da12d9c
add missing javadoc
glasser 7f34c6b
Support GraphQL-Java v12
glasser e5084f1
wrap readme
glasser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a Maven expert. Maybe @pcarrier 's eyes on at least the Maven part of the PR could help?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neithr am I, but this seems to match https://www.xolstice.org/protobuf-maven-plugin/usage.html so LGTM.