Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

router-bridge: UsageReporting: extracted methods from apollo-utils #120

Merged
merged 4 commits into from
May 20, 2022

Conversation

o0Ignition0o
Copy link
Contributor

@o0Ignition0o o0Ignition0o commented May 18, 2022

This pull request removes the copy pasted functions to generate a Usage Reporting signature, which are now refactored in apollo-utils

@o0Ignition0o o0Ignition0o marked this pull request as ready for review May 20, 2022 07:39
@o0Ignition0o o0Ignition0o changed the title wip: use the newly extracted methods from apollo-utils router-bridge: UsageReporting: extracted methods from apollo-utils May 20, 2022
@o0Ignition0o o0Ignition0o requested review from Geal, EverlastingBugstopper, abernix, bnjjj, BrynCooke and garypen and removed request for Geal May 20, 2022 07:40
@o0Ignition0o
Copy link
Contributor Author

Oh thats a new lint!

@o0Ignition0o o0Ignition0o merged commit 46fdeb3 into main May 20, 2022
@o0Ignition0o o0Ignition0o deleted the igni/refactor_usage_reporting_into_apollo_utils branch May 20, 2022 08:40
dingxiangfei2009 pushed a commit to dingxiangfei2009/federation-rs that referenced this pull request Jun 23, 2022
* fix configuration file in docs

it was not matching the configuration loader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants