chore(gateway): Remove legacy GCS fetching capabilities (`version-0.x…

…`) (#1225)

Co-authored-by: Jesse Rosenberger <[email protected]>

gateway-js/CHANGELOG.md

@@ -5,11 +5,12 @@
 > The changes noted within this `vNEXT` section have not been released yet.  New PRs and commits which introduce changes should include an entry in this `vNEXT` section as part of their development.  When a release is being prepared, a new header will be (manually) created below and the appropriate changes within that release will be moved into the new section.
 
 - __NOOP__: Fix OOB testing w.r.t. nock hygiene. Pushed error reporting endpoint responsibilities up into the gateway class, but there should be no effect on the runtime at all. [PR #1309](https://github.com/apollographql/federation/pull/1309)
+- __BREAKING__: Remove legacy GCS fetcher for schema updates. If you're currently opted-in to the backwards compatibility provided by setting `schemaConfigDeliveryEndpoint: null`, you may be affected by this update. Please see the PR for additional details. [PR #1225](https://github.com/apollographql/federation/pull/1225)
 
 ## v0.44.0
 
 - __BREAKING__: Update `@apollo/core-schema` usage and `graphql` peerDependencies. The core schema package suffered from incompatible changes in the latest graphql versions (^15.7.0). The core schema has since been updated. This updates our usage to the latest version, but in doing so requires us to update our peerDependency requirement of graphql-js to the latest v15 release (15.7.2) [PR #1140](https://github.com/apollographql/federation/pull/1140)
-- Conditional schema update based on ifAfterId [PR #TODO](https://github.com/apollographql/federation/pull/TODO)
+- Conditional schema update based on `ifAfterId` [PR #1198](https://github.com/apollographql/federation/pull/1198)
 
 ## v0.43.0
 

gateway-js/src/__tests__/integration/configuration.test.ts

@@ -110,7 +110,6 @@ describe('gateway configuration warnings', () => {
 
     gateway = new ApolloGateway({
       logger,
-      // TODO(trevor:cloudconfig): remove
       schemaConfigDeliveryEndpoint: mockCloudConfigUrl,
     });
 
@@ -300,7 +299,6 @@ describe('gateway config / env behavior', () => {
     });
   });
 
-  // TODO(trevor:cloudconfig): this behavior will be updated
   describe('schema config delivery endpoint configuration', () => {
     it('A code config overrides the env variable', async () => {
       cleanUp = mockedEnv({
@@ -318,22 +316,5 @@ describe('gateway config / env behavior', () => {
 
       gateway = null;
     });
-
-    it('A code config set to `null` takes precedence over an existing env variable', async () => {
-      cleanUp = mockedEnv({
-        APOLLO_SCHEMA_CONFIG_DELIVERY_ENDPOINT: 'env-config',
-      });
-
-      gateway = new ApolloGateway({
-        logger,
-        schemaConfigDeliveryEndpoint: null,
-      });
-
-      expect(gateway['schemaConfigDeliveryEndpoint']).toEqual(
-        null,
-      );
-
-      gateway = null;
-    });
   });
 });