Remove concat() from ConditionValidationState.advance(), which greatl…

…y increases performance in some cases
apollographql · Aug 7, 2024 · b64653d · b64653d
1 parent cae9be3
commit b64653d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/query-graphs-js/src/conditionsValidation.ts b/query-graphs-js/src/conditionsValidation.ts
@@ -25,7 +25,7 @@ class ConditionValidationState {
   ) {}
 
   advance(supergraph: Schema): ConditionValidationState[] | null {
-    let newOptions: SimultaneousPathsWithLazyIndirectPaths[] = [];
+    const newOptions: SimultaneousPathsWithLazyIndirectPaths[] = [];
     for (const paths of this.subgraphOptions) {
       const pathsOptions = advanceSimultaneousPathsWithOperation(
         supergraph,
@@ -40,7 +40,7 @@ class ConditionValidationState {
       if (!pathsOptions) {
         continue;
       }
-      newOptions = newOptions.concat(pathsOptions);
+      newOptions.push(...pathsOptions);
     }
 
     // If we got no options, it means that particular selection of the conditions cannot be satisfied, so the