Fix merging of fetch groups for @requires #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clenfest
approved these changes
Jan 26, 2022
When computing entity fetches for query plans, we keep track for an entity fetch of the path into it's "parent" group. But when doing so, we were keeping the "cast" into the entity type if present. Not only is that unecessary since entity fetches inputs/selections always start with casting into the proper entity type, it was harmful as it means that the logic for @require was sometimes not recognizing that it could merge fetches (due to those casts), sometimes yielding (obviously) ineffecient plans.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing entity fetches for query plans, we keep track for an
entity fetch of the path into it's "parent" group. But when doing so,
we were keeping the "cast" into the entity type if present. Not only
is that unecessary since entity fetches inputs/selections always start
with casting into the proper entity type, it was harmful as it means
that the logic for @require was sometimes not recognizing that it
could merge fetches (due to those casts), sometimes yielding (obviously)
ineffecient plans.