Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gateway): Resolve gateway retry issues (UplinkFetcher failed to update...) (version-0.x) #1503

Merged
merged 8 commits into from
Feb 10, 2022
Merged

fix(gateway): Resolve gateway retry issues (UplinkFetcher failed to update...) (version-0.x) #1503

merged 8 commits into from
Feb 10, 2022

Commits on Feb 10, 2022

  1. Failing test

    @trevor-scheer
    trevor-scheer committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    8de3c6b View commit details
    Browse the repository at this point in the history

  2. Fix duped error messages

    @trevor-scheer
    trevor-scheer committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    4c69b2a View commit details
    Browse the repository at this point in the history

  3. Un-globalize the fetch count (keep it in the UplinkFetcher class as s… 

    …tate)
    @trevor-scheer
    trevor-scheer committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    d7d89e8 View commit details
    Browse the repository at this point in the history

  4. Rework retry logic 

    The current gateway supergraph fetch retry logic doesn't
handle the `null` case correctly. It treats `null` as a
retry-able result, when it's actually the most common case
(meaning no schema change).

In the success case (result = SupergraphSdlUpdate | null)
we now clear any exceptions that may have been caught during
retry so that they aren't thrown.

This also introduces the `async-retry` package which nicely
wraps the retry logic for us and manages exponential backoff.
    @trevor-scheer
    trevor-scheer committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    632b974 View commit details
    Browse the repository at this point in the history

  5. Update changelog

    @trevor-scheer
    trevor-scheer committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    f74eaf0 View commit details
    Browse the repository at this point in the history

  6. Update test to expected behavior

    @trevor-scheer
    trevor-scheer committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    fc9580b View commit details
    Browse the repository at this point in the history

  7. Address feedback

    @trevor-scheer
    trevor-scheer committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    39b9ffb View commit details
    Browse the repository at this point in the history

  8. Merge branch 'version-0.x' into trevor/fix-round-robin-issues

    @trevor-scheer
    trevor-scheer authored Feb 10, 2022
    Configuration menu
    Copy the full SHA
    1216f47 View commit details
    Browse the repository at this point in the history