Fix applying auto-imported federation directive on other directive de… #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…finition For subgraphs, applying an auto-imported federation directive (say `@tag`) to another directive definition argument was triggering a non-sensical error. That is because we want trying to handle such directive application _before_ we had properly auto-imported its definition. This patch ensure we delay the building of such directive application to after the auto-importing mechanism has been performed. Fixes apollographql#1794
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Sorry, looks like github auto-closed this when the base branch got deleted. I don't seem to be able to change the branch or reopen this. |
|
Yeah, somehow I'm failing at resurrecting this as well. Well, no matter, I created #1797 to replace it with the commit rebased on main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…finition
For subgraphs, applying an auto-imported federation directive (say
@tag) to another directive definition argument was triggering anon-sensical error. That is because we want trying to handle such
directive application before we had properly auto-imported its
definition.
This patch ensure we delay the building of such directive application
to after the auto-importing mechanism has been performed.
Fixes #1794