Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @key repeatable in subgraph-js #1826

Merged
merged 3 commits into from
May 9, 2022
Merged

Conversation

benweatherman
Copy link
Contributor

We don't use this anywhere, but it will ensure that anyone looking for directives sees the proper definition. I opted to not add tests since this code may not be long for the world.

Fixes #1819

We don't use this anywhere, but it will ensure that anyone looking for directives sees the proper definition. I opted to not add tests since this code may not be long for the world.

Fixes #1819
@netlify
Copy link

netlify bot commented May 4, 2022

Deploy Preview for apollo-federation-docs ready!

Name Link
🔨 Latest commit 44f4739
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/627921db60cbe70009149b55
😎 Deploy Preview https://deploy-preview-1826--apollo-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@benweatherman benweatherman enabled auto-merge (squash) May 9, 2022 14:15
@benweatherman benweatherman merged commit 842082b into main May 9, 2022
@benweatherman benweatherman deleted the weatherman/key-repeatable branch May 9, 2022 14:18
@benweatherman benweatherman mentioned this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@key definition in subraph-js should specify it's repeatable
2 participants