Fix bug when field covariance meet type-explosion #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
As we build selection sets during query planning, and due to how query planning work, we have cases where we try to add an interface field (as coming from the original query) to a selection set whose parent type is one of the interface implementation. As we do, the code recognize this case and make sure to use the proper implementation field instead (so that the resulting selection remains a well-typed object). But that code was slightly buggy in 2 small ways (we updated the field added, but didn't update its sub-selection set accordindly, and `SelectionSet#add` method was returning the original selection instead of the added (and potentially updated) one). This fixes those issues. Fixes apollographql#1858
pcmanus
force-pushed
the
1858-covariance-bug
branch
from
cf3261a
to
f216dbc
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we build selection sets during query planning, and due to how query
planning work, we have cases where we try to add an interface field (as
coming from the original query) to a selection set whose parent type is
one of the interface implementation. As we do, the code recognize this
case and make sure to use the proper implementation field instead (so
that the resulting selection remains a well-typed object). But that
code was slightly buggy in 2 small ways (we updated the field added,
but didn't update its sub-selection set accordindly, and
SelectionSet#addmethod was returning the original selection insteadof the added (and potentially updated) one). This fixes those issues.
Fixes #1858