Fix node-fetch runtime build-time regression #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1970 seems to have caused a regression based on `@types/node-fetch` not being in the gateway's runtime dependencies
✅ Deploy Preview for apollo-federation-docs canceled.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Grmiade
reviewed
Aug 30, 2022
trevor-scheer
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
I'd clarify in the title that this is only a build-time regression (i.e. non-TS users should be unaffected). The types package is needed in dependencies since dev dependencies aren't installed into node_modules but the types must be present for the gateway package to build due to the node-fetch import in the .d.ts file.
edit: compilation is part of the install lifecycle so probably also affecting non-TS users but still not at runtime 😄
clenfest
changed the title
clenfest
changed the title
clenfest
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1970 seems to have caused a regression based on
@types/node-fetchnot being in the gateway's runtime dependenciesFixes #2113