Any 403 with AccessDenied message should be omitted #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These errors appear to continue to bubble up to users. This changes our error-handling to omit any 403 with the string "AccessDenied" in its text when communicating with `federation.api.apollographql.com`
trevor-scheer
approved these changes
Oct 19, 2020
Co-authored-by: Trevor Scheer <[email protected]>
|
@zionts make sure you squash & merge next time if it wasn't on purpose (with gh defaults and all..) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These errors appear to continue to bubble up to users. This changes our
error-handling to omit any 403 with the string "AccessDenied" in its
text when communicating with
federation.api.apollographql.com