-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: chore(@override): add e2e testing of progressive overriding #2978
base: main
Are you sure you want to change the base?
Conversation
@metrue: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
…uery for every request to control the on/off based on the label
…uery for every request to control the on/off based on the label
Confirmed with Apollo team, the progressive feature for But if we really need to do it on the federation/gateway, we can do a little hacking in the queryplan building but it will lose the queryplan caching. I tried this commit 1da5e43, now you can see the CI is passed, but obviously it's a thing to try on production. |
This PR is trying to validate if the
@override
behaves correctly when the progressive label applied, because when I trying to move one of my entities from a subgraph to another subgraph, I tried to leverage this progressive overriding to shift the traffic gradually, but the result observed,label
applied, the overriding field will always be resolved in the new subgraphlabel
applied, the overriding field will always be resolved in the old subgraphI did read the document in Apollo website, and doubled check my schema design for our internal service, I did not find anything wrong, so I am opening this PR to validate
@override(from: string, label: string)
, and you can see the test result proved above conclusion:label
not working as expecting, when label applied, the resolving always happens in the old subgraph.Could someone help review it and explain a little bit if I am doing it correct?