Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various setContext bug fixes #3017

Merged
merged 5 commits into from
May 29, 2024
Merged

various setContext bug fixes #3017

merged 5 commits into from
May 29, 2024

Commits on May 23, 2024

  1. Some bugfixes for setContext

    - needsJoinDirective() logic is incorrect. We need to make sure that we add a join field when @fromDirective exists on the arguments, not the definition
    - Query plans were incorrect if type was entirely in one subgraph. selectionIsFullyLocalFromAllVertices was calling SelectionSet.canRebaseOn so we fixed to return false if the selection contained a field with a contextual argument
    - For top level queries, we don't want to have "... on Query" in the rewrite path.
    - Fixed up  selectionSetAsKeyRenamers() logic
    clenfest committed May 23, 2024
    Configuration menu
    Copy the full SHA
    fe49571 View commit details
    Browse the repository at this point in the history
  2. add changeset

    clenfest committed May 23, 2024
    Configuration menu
    Copy the full SHA
    e492f50 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d667dba View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Configuration menu
    Copy the full SHA
    dcd8a88 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Configuration menu
    Copy the full SHA
    70a97b0 View commit details
    Browse the repository at this point in the history