Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(federation): Prevent @tag and @inaccessible usages on fields marked @external #869

Closed
wants to merge 10 commits into from
Closed

fix(federation): Prevent @tag and @inaccessible usages on fields marked @external #869

wants to merge 10 commits into from

Commits on Jul 13, 2021

  1. Demonstrate bug with test

    @trevor-scheer
    trevor-scheer committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    beaa09e View commit details
    Browse the repository at this point in the history

  2. Fix the bug and update test

    @trevor-scheer
    trevor-scheer committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    f32cf94 View commit details
    Browse the repository at this point in the history

  3. DRY up logic for capturing known directive usages 

    Also rename 'appliedDirectives' to 'otherKnownDirectives'
    @trevor-scheer
    trevor-scheer committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    83a343f View commit details
    Browse the repository at this point in the history

  4. Move test

    @trevor-scheer
    trevor-scheer committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    2421b3c View commit details
    Browse the repository at this point in the history

  5. Update approach - disallow @tag and @external together 

    This reverts most of the previous implementation in favor of a new
composition error which prevents users from confusingly using both
@tag and @external together. For now, @tag is expected to have
implications with schema contracts and in the context of an external
field, it's not well-defined what that would actually mean. We may
revisit and relax this in the future, but for now have decided to
just prevent the possible confusion.
    @trevor-scheer
    trevor-scheer committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    243e731 View commit details
    Browse the repository at this point in the history

  6. Add missing newline

    @trevor-scheer
    trevor-scheer committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    be3f919 View commit details
    Browse the repository at this point in the history

  7. Update tests

    @trevor-scheer
    trevor-scheer committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    884da2c View commit details
    Browse the repository at this point in the history

  8. Also validate against improper @inaccessible usage

    @trevor-scheer
    trevor-scheer committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    3d51e58 View commit details
    Browse the repository at this point in the history

  9. Naming: clarity between usages and definitions

    @trevor-scheer
    trevor-scheer committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    9922bb9 View commit details
    Browse the repository at this point in the history

  10. Add changelog entry

    @trevor-scheer
    trevor-scheer committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    3c67410 View commit details
    Browse the repository at this point in the history