-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(federation): Remove the notion of @inaccessible from subgraphs #880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trevor-scheer says that making progress today on another PR will be much easier if this PR is merged now, and that appropriate reviewers aren't available in this time zone now. Clicking the green button without a real review; @trevor-scheer will find somebody to do post-merge review.
Had a quick post-merge review look and didn't spot any obvious issue. One remark that crossed my mind is: what we mostly wanted here was the updates to |
Good question! I found an internal thread which helped me answer this. Preserving the handling may still make sense but currently that functionality is not necessitated by the Studio team. We can re-introduce it if they need it for their use cases but since that is the only current use-case (that I'm aware of) I think it's fine to leave it out. cc @jsegaran in case you want to propose it be introduced eventually!, but I can also see this need being superseded by a more principled way of directive life-cycle management that we already have in mind. |
Thanks for taking a look and your intuition matched mine @pcmanus. As @abernix mentioned, I did end up considering this (after the fact) and fortunately it seems Studio doesn't need that functionality. If we ever do need to reintroduce it though, this PR will make for a great reference of what to re-undo 😄 |
We've decided to go forward with the decision to ignore the usage of @inaccessible at the subgraph level, and instead allow @inaccessible to be a result of using @tag + Studio governance.
This directly relates to #869 but will take precedence due to the updated decision.
This PR also handles the rename of
appliedDirectives
recommended in feedback on #859.Fixes #867.