Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update to graphql@15 #299

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

adriencohen
Copy link
Contributor

Closes #298

@apollo-cla
Copy link

@adriencohen: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@theprobugmaker
Copy link

bump

1 similar comment
@barbieri
Copy link

barbieri commented Jun 9, 2020

bump

Copy link

@dominicporter-MG dominicporter-MG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using graphql-tag with graphql 15.0.0 and it all seems to work (apart from the Peer Dep warning when you do npm i...

@airhorns
Copy link

airhorns commented Jun 24, 2020

It'd be great to get this in! It'd actually fix #298 . I think that issue is that specific user's issue where the typescript definitions aren't compatible between the two different versions of graphql-js included in his project. If we bumped the peer dependency of graphql-tag, the package manager could resolve graphql-js to the same version and actually make that issue go away!

I've been using graphql-tag with version 15 (just by forcing my package manager) and it has been working well for me. It'd be great to get this in.

@tunegov
Copy link

tunegov commented Jun 24, 2020

Merge it, please!

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adriencohen!

@hwillson hwillson merged commit 7b66f05 into apollographql:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphql 15 compatibilty
8 participants