Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Commit

Permalink
Use lodash-es for ES modules (#1344)
Browse files Browse the repository at this point in the history
* Use lodash-es for ES modules

* Allow lodash-es modules to be transformed for Jest

* Resolve CI errors

- Update lodash types
- Add babelify to Transform node_modules/lodash-es for Browserify build
- Add changelog entry
  • Loading branch information
corydeppen authored and James Baxley committed Dec 8, 2017
1 parent 7496ea6 commit 8085a94
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 7 deletions.
3 changes: 3 additions & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# Change log

### vNext
- Use lodash-es to allow lodash functions to be used in ES modules [#1344](https://github.com/apollographql/react-apollo/pull/1344)

### 2.0.1

- upgraded required apollo-client for bugfix for subscriptions
- add component name in unhandled error message [#1362](https://github.com/apollographql/react-apollo/pull/1362)
Expand Down
14 changes: 10 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"bundle":
"rollup -c && rollup -c rollup.browser.config.js && rollup -c rollup.test-utils.config.js",
"compile:browser":
"rm -rf ./dist && mkdir ./dist && NODE_ENV=production browserify ./lib/react-apollo.browser.umd.js --i graphql-tag --i react --i apollo-client -o=./dist/index.js && npm run minify:browser && npm run compress:browser",
"rm -rf ./dist && mkdir ./dist && NODE_ENV=production browserify ./lib/react-apollo.browser.umd.js --i graphql-tag --i react --i apollo-client -o=./dist/index.js -t [ babelify --global true --only lodash-es --presets [ env ] ] && npm run minify:browser && npm run compress:browser",
"minify:browser":
"uglifyjs --compress dead_code=true,unused=true -m -o ./dist/index.min.js -- ./dist/index.js",
"compress:browser": "./scripts/gzip.js --file=./dist/index.min.js",
Expand Down Expand Up @@ -71,6 +71,9 @@
"transform": {
".*": "./preprocessor.js"
},
"transformIgnorePatterns": [
"<rootDir>/node_modules/(?!(lodash-es|react-native)/)"
],
"moduleFileExtensions": ["ts", "tsx", "js", "json"],
"modulePathIgnorePatterns": [
"<rootDir>/examples",
Expand All @@ -92,7 +95,8 @@
"@types/invariant": "2.2.29",
"@types/isomorphic-fetch": "0.0.34",
"@types/jest": "20.0.8",
"@types/lodash": "4.14.74",
"@types/lodash": "4.14.86",
"@types/lodash-es": "4.17.0",
"@types/node": "8.0.31",
"@types/object-assign": "4.0.30",
"@types/react": "16.0.28",
Expand All @@ -105,8 +109,11 @@
"@types/zen-observable": "0.5.3",
"apollo-cache-inmemory": "1.1.3",
"apollo-client": "2.1.0",
"babel-core": "^6.26.0",
"babel-jest": "20.0.3",
"babel-preset-env": "^1.6.1",
"babel-preset-react-native": "3.0.2",
"babelify": "^8.0.0",
"browserify": "14.4.0",
"bundlesize": "0.14.4",
"cheerio": "0.22.0",
Expand Down Expand Up @@ -159,8 +166,7 @@
"apollo-link": "^1.0.0",
"hoist-non-react-statics": "^2.2.0",
"invariant": "^2.2.1",
"lodash.flowright": "^3.5.0",
"lodash.pick": "^4.4.0",
"lodash-es": "^4.17.4",
"prop-types": "^15.5.8"
}
}
4 changes: 2 additions & 2 deletions src/browser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ export { withApollo } from './withApollo';
export { getDataFromTree } from './getDataFromTree';

// expose easy way to join queries from redux
import * as compose from 'lodash.flowright';
export { compose };
import flowRight from 'lodash-es/flowRight';
export { flowRight as compose };
2 changes: 1 addition & 1 deletion src/graphql.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import shallowEqual from './shallowEqual';

const invariant = require('invariant');
const assign = require('object-assign');
const pick = require('lodash.pick');
import pick from 'lodash-es/pick';

This comment has been minimized.

Copy link
@KittyGiraudel

KittyGiraudel Dec 8, 2017

Hello there! 👋

Are you sure this is intended? This causes an error in our build.

SyntaxError: Unexpected token import
    at createScript (vm.js:80:10)
    at Object.runInThisContext (vm.js:139:10)
    at Module._compile (module.js:599:28)
    at Object.Module._extensions..js (module.js:646:10)
    at Module.load (module.js:554:32)
    at tryModuleLoad (module.js:497:12)
    at Function.Module._load (module.js:489:3)
    at Module.require (module.js:579:17)
    at require (internal/module.js:11:18)
    at /goldfish/node_modules/react-apollo/react-apollo.umd.js:2:123
/goldfish/node_modules/lodash-es/pick.js:1
(function (exports, require, module, __filename, __dirname) { import basePick from './_basePick.js';

Or did I miss something?


const hoistNonReactStatics = require('hoist-non-react-statics');

Expand Down

0 comments on commit 8085a94

Please sign in to comment.