This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Forward-port #1181 to 2.0 #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identical to #1181 which didn't make it to 2.0. Test fails because it uses networkInterface. Next commit will fix for 2.0 API.
glasser
force-pushed
the
glasser/forward-port-1181
branch
from
1ca304b
to
8da7a8f
Compare
This was referenced Nov 9, 2017
peggyrayzis
approved these changes
Nov 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1181 seems to have not made it to react-apollo 2.0. This PR cherry-picks the change and updates the test to 2.0.