Dependencies update, typescript check tests, fix hoc inference

[rosskevin]

testing privately (all good so far), but feel free if you want to ping me to confirm before squash+merge

Summary

This PR is largely housekeeping and the fallout from dependency updates. There are no runtime changes included in this PR with the exception of removing the one deprecated skip prop.

• Jest 20->21 required some test assertion changes for which I created a custom matcher.
• Tests are all now valid typescript and pass tslint
• Remove deprecated operationOptions.options.skip, use operationOptions.skip instead

Typescript summary

Typescript types have been refactored for consistency and a focus on typescript user experience. This means consistent parameterized type names, types have been refactored and exported individually, and changes made to the signature (exported type names were not changed).

• Fix graphql hoc inference type signature
• Make all test sources type check (closes test sources have typescript errors and are not checked in yarn type-check #1404)
• Greater reuse of types types.ts
• Fix shouldResubscribe props on OperationOption
• graphql parameterized types streamlined for a) full typing; and b) ease of use; and c) consistency. New parameterized usage is: graphql<TProps, TData, TGraphQLVariables, TChildProps> where none are required and full typing only requires the first three params (TChildProps can be derived). The first three params will be most typical when used in conjunction with apollo-codegen. Note the ordering of graphql parameters is different to be consistent with ChildProps and variants and to minimize verbosity (supersedes Fully type ChildProps and reorder graphql() types to reduce verbosity #1395)
• Add ChildDataProps and ChildMutateProps for optional stronger typed usage version of ChildProps, and can be used as the fourth parameter to graphql. This is in preparation for a potential split query vs mutation usage of the graphql component.

Misc

• Update all dependencies
• Update script usage - remove any deprecations
• Update jest setup
• Update prettier setup
• Update typescript setup
• Run lint-fix (prettier + tslint --fix)
• Remove integration tests/samples for external libraries (out of date and not necessary for unit testing)

[apollo-cla]

	Fails
🚫	Danger failed to run dangerfile.ts.

Error SyntaxError

Unexpected token import
dangerfile.ts:1
(function (exports, require, module, __filename, __dirname) { import { includes } from 'lodash';
                                                              ^^^^^^

SyntaxError: Unexpected token import
    at createScript (vm.js:80:10)
    at Object.runInThisContext (vm.js:139:10)
    at Module._compile (module.js:599:28)
    at requireFromString (/home/travis/build/apollographql/react-apollo/node_modules/require-from-string/index.js:28:4)
    at Object.<anonymous> (/home/travis/build/apollographql/react-apollo/node_modules/danger/distribution/runner/runners/inline.js:96:21)
    at step (/home/travis/build/apollographql/react-apollo/node_modules/danger/distribution/runner/runners/inline.js:32:23)
    at Object.next (/home/travis/build/apollographql/react-apollo/node_modules/danger/distribution/runner/runners/inline.js:13:53)
    at /home/travis/build/apollographql/react-apollo/node_modules/danger/distribution/runner/runners/inline.js:7:71
    at new Promise (<anonymous>)
    at __awaiter (/home/travis/build/apollographql/react-apollo/node_modules/danger/distribution/runner/runners/inline.js:3:12)

Dangerfile

75|     fail('Please add a description to your PR.');
76|   }
77| 
78|   const hasAppChanges = modifiedAppFiles.length > 0;
79| 
------------^
80|   const hasTestChanges = modifiedTestFiles.length > 0;
81| 
82|   // Warn when there is a big PR
83|   const bigPRThreshold = 500;

Generated by 🚫 dangerJS

[rosskevin]

My last push is broken, it is failing with errors such as:

Expected value to equal:
  {"people": [{"name": "Luke Skywalker"}]}
Received:
  {"people": [{"name": "Luke Skywalker", Symbol(id): "$ROOT_QUERY.allPeople({\"first\":1}).people.0"}], Symbol(id): "$ROOT_QUERY.allPeople({\"first\":1})"}

I found this somewhat related SO post, except ironically we aren't trying to get the Symbol(id), it is just showing up. I moved to typescript recently from flow, so maybe this is just something common I haven't bumped into.

It could be a problem with matcher toEqual (unlikely), or the transformation of data to the prop could be errantly putting a literal Symbol(id) in (seems more likely). I can only surmise this is caused by a dependency update, but it seems that I incrementally had good-ish builds all the way up to the jest/danger update.

@jbaxleyiii any thoughts/guidance here? I'd like to get this PR to the finish line.

[rosskevin]

The upgraded jest isEqual is aware of symbols, so several tests are failing.

It seems expect(props.data.allPeople).toEqual(data1.allPeople) will need to be the equivalent of

expect(JSON.parse(JSON.stringify(props.data.allPeople))).toEqual(
  data1.allPeople,
);

I'm making a utility method to serialize/deserialize to wash out the symbols for comparison to the hardcoded fixtures.

[rosskevin]

I'm going to publish this privately and start integrating with our codebase to ensure no errors in typing that I didn't already uncover with the tests.

[orta]

@rosskevin - I'd recommend updating Danger to 2.x, it stops relying on Jest internals then 👍

[rosskevin]

@orta I updated to 2.1.4 - so perhaps that is the problem - any guide for 2.x and TS? I saw a bunch of TS related docs removed from the repo.

[orta]

Should "just work" will clone and look now.

[orta]

Interesting, so the results of running the ts transpiler with your tsconfig.json seems to be that it produces imports instead of requires.

e.g. with the tsconfig, and with an empty config.

Digging into see if there's something I'm doing wrong in Danger

---

I think in this case Danger needs to override/remove the module option in a user's tsconfig. Can't see a use-case where it should be needed.

[orta]

OK, want to try updating to 2.1.5 please?

When I update & run node --inspect node_modules/danger/distribution/commands/danger-pr.js https://github.com/apollographql/apollo-client/pull/2476 with that in your PR - it passes

[rosskevin]

Thanks @orta! danger ran without a problem.

[orta]

Thanks for poking me - I had a PR on our RN repo which exhibited the same issue artsy/emission#804

[rosskevin]

@jbaxleyiii all green, ready for review. In the meantime I'm working with the package in our codebase to find any inconsistencies with the types.

[rosskevin]

Amazing, committed a script change some other test fails. We need a better way than timing, because clearly travis is inconsistent.

[rosskevin]

I'm never committing again for fear of breaking the time-dependent tests on travis 😳

[jbaxleyiii]

@rosskevin this is absolutely INCREDIBLE WORK. Thank you SO SO much for showing the imitative and commitment here!

I'm good to merge this!