Removed the react-native test. #1451
Conversation
|
Note, this is WIP. I am completing this as soon as I find some more time. |
|
I can confirm that the test What should we do with this test? It seems that this test has nothing to do with |
|
@excitement-engineer can you rebase - I'd like to get this one merged. |
| const globalAny: any = global; | ||
|
|
||
| globalAny.requestAnimationFrame = callback => { | ||
| setTimeout(callback, 0); |
There was a problem hiding this comment.
This is the long way to type it, you could just do (global as any).requestAnimationFrame
|
It seems like the ci is not starting, maybe travis is down. The ci will not pass because of the broken test. Given that it seems to be testing something internal in apollo-client. Perhaps we should simply delete the test |
|
If you resolve conflicts and push a change, it will run. |
# Conflicts: # Changelog.md
This PR removes the only react-native test in the repo. I don’t really see the value of including this test in the repo, in addition it adds complexity with the jest configurations and adds some other devDependencies which can now be removed.