Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Updated lint rule to make prettier responsible for formatting. #1452

Merged

Conversation

excitement-engineer
Copy link
Contributor

Following #1449, attempt 2 at making prettier responsible for formatting.

I used a tool to remove all the lint rules that conflicted with prettier in the tslint.json. I also tested it on the file Query.tsx that is causing issues in #1448.

This allowed me to remove tslint-config-prettier as a dependency.

Finally, I also updated the pretty script and the lint-staged script in the package.json.

@excitement-engineer
Copy link
Contributor Author

cc @rosskevin

@apollo-cla
Copy link

apollo-cla commented Dec 23, 2017

Warnings
⚠️

There are library changes, but not tests. That's OK as long as you're refactoring existing code

Generated by 🚫 dangerJS

@rosskevin rosskevin merged commit 5a56897 into apollographql:master Dec 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants