Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Remove copied shallowEqual code - use fbjs #1465

Merged
merged 3 commits into from
Dec 26, 2017

Conversation

rosskevin
Copy link
Contributor

  • Remove copied code shallowEqual and delegate to fbjs
  • change tsconfig.json to allow for direct import = require of commonjs modules

@apollo-cla
Copy link

apollo-cla commented Dec 26, 2017

Warnings
⚠️

There are library changes, but not tests. That's OK as long as you're refactoring existing code

Generated by 🚫 dangerJS

@rosskevin rosskevin merged commit de1edc8 into apollographql:master Dec 26, 2017
@rosskevin rosskevin deleted the remove-copied-shallowequal branch December 26, 2017 20:32
@evocateur
Copy link

Adding a dependency on fbjs for one function seems a rather Pyrrhic victory. Now anyone bundling this library gets a giant blob of unused, non-tree-shakeable code. :/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants