Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Import/export/package cleanup #1467

Merged
merged 7 commits into from
Dec 26, 2017

Conversation

rosskevin
Copy link
Contributor

@rosskevin rosskevin commented Dec 26, 2017

Goal: Address inconsistencies with import/exports, some type naming, and package creation

Summary: Ultimately, we were building and maintaining a browser.ts and server.ts and the payoff was negligible. Simplify indexes/builds/imports/exports and related names for consistency.

  • use index.ts as primary accumulation of exports
  • update exported types to be more unique to avoid collisions (pattern is set by Query.tsx more work needed here as we refactor graphql.tsx into Query/Mutate/Subscribe)
  • update deprecated rollup configs
  • measure only react-apollo.umd.js bundle (so small this is not worth maintaining/compiling two packages)
  • reduce bundlesize limit to help show errors
  • adjust prepare-package.sh to point to correct files
  • revert tsconfig (mine) change to unsure es2015 is produced for optional package.module use
  • move umd output in package to umd dir

@rosskevin rosskevin merged commit 5696fb8 into apollographql:master Dec 26, 2017
@rosskevin rosskevin deleted the import-export-cleanup branch December 26, 2017 22:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant