Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Added prop-types validation to unchecked components. #1587

Merged

Conversation

excitement-engineer
Copy link
Contributor

Added prop-types validation to the <Query />, <Subscription /> and <ApolloConsumer /> component

Copy link
Contributor

@rosskevin rosskevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increase the bundle size - otherwise looks good.

@jbaxleyiii
Copy link
Contributor

ugh, I hate prop-types in libraries but since we use context I guess we have them already? With the move to react's new context though I wonder if depending on prop-types will be necessary? If not, I'd like to not ship them anymore?

Thoughts? Are they still used / valuable?

@excitement-engineer
Copy link
Contributor Author

I personally don't use them as I use flow on all my react projects. However, for those that don't use any typings they could be valuable. I know that react-router uses them for example.

@jbaxleyiii jbaxleyiii merged commit 1426447 into apollographql:master Feb 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants