Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Use client from props in Mutation component #1890

Merged
merged 6 commits into from
Jun 18, 2018
Merged

Use client from props in Mutation component #1890

merged 6 commits into from
Jun 18, 2018

Conversation

amneacsu
Copy link
Contributor

@amneacsu amneacsu commented Apr 3, 2018

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • If this was a change that affects the external API used in GitHunt-React, update GitHunt-React and post a link to the PR in the discussion.

@apollo-cla
Copy link

@amneacsu: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@jbaxleyiii
Copy link
Contributor

@amneacsu would you be able to add a test for this?

@amneacsu
Copy link
Contributor Author

amneacsu commented Apr 6, 2018

Hi @jbaxleyiii does this work? I have shamefully little experience with writing tests.

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @amneacsu! As soon as the tests go ✅ on the current run, we should be all set here.

@hwillson hwillson merged commit 6c5ad5f into apollographql:master Jun 18, 2018
@hwillson hwillson mentioned this pull request Jun 21, 2018
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants