Add onCompleted prop to Query

[jeshep]

Allows a function to be passed into the Query component that will be run once the query has completed. Useful for modifying the local state with data from a query, e.g. initialize the select value to the first item from the query results.

Reference Issue: #1862

Not sure if there is a better place in the Query component to call the provided onCompleted function, but this implementation seems to work.

Checklist:

• [] If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
• Make sure all of the significant new logic is covered by tests
• If this was a change that affects the external API used in GitHunt-React, update GitHunt-React and post a link to the PR in the discussion.

[apollo-cla]

@jeshep: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

[tab00]

I hope this will be merged soon, as I actually need it right at this moment.

[tab00]

What's the hold up? This should have been in the original implementation.

[ajoslin]

Ping. This needs to happen. I'm forced to use withApollo and props.client.query in componentDidMount until this lands.

[dispix]

Was about to open the same PR when I saw yours. This feature would be indeed much appreciated, especially with the new render prop approach that makes the data unavailable through props.

Shouldn't this PR also includes an onError prop ?

[jimshepherd]

Added onError prop to the PR.

Would be nice to get some feedback on this PR from the maintainers.

[ajoslin]

Apollo devs, how can we support in getting this merged? This would really help.

[jarommadsen]

Would love to see this make it through. Haven't peeked at the changes yet but will onCompleted be fired on fetchMore?

[hwillson]

This is awesome @jeshep - thanks very much for working on this (and sorry for the long delay)! We're all set here, but I'll hold off on merging for a few more mins while I get the API docs updated in the apollo-client repo. Thanks again!

[jimshepherd]

Awesome! Glad I could contribute.

[ajoslin]

🎉

[olistic]

Hi! Would anyone in this thread mind shedding some light on #2177? It looks like an oversight of this PR, but maybe it's not and it's by design. Thanks!