<Subscription /> <Query /> & <Mutation /> consume the apollo client the same way. #1956

quentin- · 2018-04-30T02:13:28Z

👋,

This PR:

marks the client optional in both context and props in all three component
update the client correctly when props are updated.
always use the prop client over the context
throw error if no client

Checklist:

Make sure all of the significant new logic is covered by tests

…r context client.

…Query />

…ptional-context-client

hwillson

Thanks for working on this @quentin-! We should be all set here - LGTM!

quentin- added 7 commits April 29, 2018 19:07

Mark Query context client as optional and always use props client ove…

9a6d361

…r context client.

write test as an array of steps

a9512d1

better test

41cca48

Merge branch 'master' into query-component-optional-context-client

a573f3d

cleanup

f4570e0

Change <Mutation /> to share client same behaviour and interface of <…

0b1251a

…Query />

Merge branch 'master' into query-component-optional-context-client

c69e101

quentin- changed the title ~~Mark Query context client as optional and always use props client ove…~~ Consolidate how <Query /> and <Mutation /> fetch the apollo client from Jun 2, 2018

quentin- and others added 3 commits June 2, 2018 16:25

fix error message

f4c5fe4

Merge branch 'master' into query-component-optional-context-client

3964f4a

update <Subscriptions /> too

d7d1ceb

quentin- changed the title ~~Consolidate how <Query /> and <Mutation /> fetch the apollo client from~~ <Subscription /> <Query /> & <Mutation /> consume the apollo client the same way. Jun 8, 2018

Merge branch 'master' into query-component-optional-context-client

12a26ae

quentin- mentioned this pull request Jun 17, 2018

use props.client first in Query/Mutation/Subscription #2112

Closed

3 tasks

hwillson mentioned this pull request Jun 21, 2018

Custom client on Mutations #1943

Closed

3 tasks

hwillson self-assigned this Jun 21, 2018

rosskevin approved these changes Jul 3, 2018

View reviewed changes

hwillson added 4 commits September 20, 2018 08:53

Merge remote-tracking branch 'upstream/master' into query-component-o…

d17952d

…ptional-context-client

Remove unnecessary code from merge

9e20ede

Remove duplicate client from merge

ca8895e

Changelog update

bceeff3

hwillson approved these changes Sep 20, 2018

View reviewed changes

hwillson merged commit c21e005 into apollographql:master Sep 20, 2018

dependencies bot mentioned this pull request Sep 26, 2018

Update react-apollo in / from 2.0.1 to 2.2.0 LibreTubeApp/LibreTube#200

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

<Subscription /> <Query /> & <Mutation /> consume the apollo client the same way. #1956

<Subscription /> <Query /> & <Mutation /> consume the apollo client the same way. #1956

quentin- commented Apr 30, 2018 •

edited

Loading

hwillson left a comment

<Subscription /> <Query /> & <Mutation /> consume the apollo client the same way. #1956

<Subscription /> <Query /> & <Mutation /> consume the apollo client the same way. #1956

Conversation

quentin- commented Apr 30, 2018 • edited Loading

Checklist:

hwillson left a comment

Choose a reason for hiding this comment

quentin- commented Apr 30, 2018 •

edited

Loading