This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Check if queryManager is set before accessing it #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosskevin
approved these changes
Jul 6, 2018
|
Thanks @danilobuerger! |
|
This fix was published on |
|
I'm still seeing this |
|
It wasn't released in 2.1.9 |
danilobuerger
added a commit
to danilobuerger/react-apollo
that referenced
this pull request
Aug 2, 2018
Added Changelog for: * apollographql#2151 * apollographql#2165
|
When is this being released? |
|
Was released in 2.1.11 |
hwillson
pushed a commit
that referenced
this pull request
Aug 17, 2018
|
I am getting the error around same scenario in react-apollo/test-utils.js
This is happening because of cleanup in Do you think this should be raised as a new issue OR is there anything I am doing wrong in my setup. My dependencies : {
"graphql": "0.13.0",
"graphql-tag": "^2.10.1",
"react": "^16.8.4",
"react-apollo": "^2.5.2",
"react-dom": "^16.8.4",
"react-router-dom": "^5.0.0",
"react-scripts": "2.1.8"
},I have tried different versions of react-apollo : Below is the error : Below is my code block : import React from 'react';
import { Query } from 'react-apollo';
import { render } from 'react-testing-library';
import 'react-testing-library/cleanup-after-each';
import { MockedProvider } from 'react-apollo/test-utils';
import wait from 'waait';
import queryGethAllApps from 'graphql/queries/get-all-apps';
function FeatureList({ refetch }) {
return (
<Query
query={queryGethAllApps}
fetchPolicy={refetch ? 'cache-and-network' : 'cache-first'}
>
{({ loading, data: { listFtApplications } }) => {
if (loading) return <span>loading....</span>;
return <span>feature lists</span>;
}}
</Query>
);
}
test('It renders feature list component', async () => {
const mocks = [
{
request: {
query: queryGethAllApps
},
result: {
data: {
listFtApplications: {
items: [{ id: '123', name: 'mock test' }]
}
}
}
}
];
const { getByText, asFragment } = render(
<MockedProvider mocks={mocks} addTypename={false}>
<FeatureList />
</MockedProvider>
);
await wait(0);
expect(asFragment()).toMatchSnapshot();
expect(getByText('feature lists')).toBeInTheDocument();
}); |
I am getting this exact same error with |
|
Hello @ashoksudani, can you open an issue with your error, please? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2164 . Sorry for breaking the release :(.