Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

fix: When doing a SSR with errorPolicy='all', then error should not be lost #2753

Merged
merged 2 commits into from
Jan 28, 2019
Merged

fix: When doing a SSR with errorPolicy='all', then error should not be lost #2753

merged 2 commits into from
Jan 28, 2019

Commits on Jan 28, 2019

  1. fix: When doing a SSR with errorPolicy='all', then error should not b… 

    …e lost
    @benjamn
    Mike McLafferty authored and benjamn committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    9d2eac9 View commit details
    Browse the repository at this point in the history

  2. Replace getDataFromTree Trie class with two-layered Map. 

    This Trie class was only ever used to look up sequences of two elements,
where the first element was always a DocumentNode and the second element
was always a string.

PR #2753 by @mikebm highlighted the fact that the Trie was not as easy to
reuse as it was originally intended to be. By comparison, a simple
Map<DocumentNode, Map<string, QueryInfo>> data structure has better type
safety and a clearer purpose, while enabling easier extensions (just add
new fields to QueryInfo and update the makeDefaultQueryInfo function).
    @benjamn
    benjamn committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    34ab44b View commit details
    Browse the repository at this point in the history