This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Allow resolvers to be passed into MockedProvider and set a default
#2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the changes in apollographql/apollo-client#4499, when `MockedProvider` is currently used it doesn't have any `resolvers` set. This means `@client` directives are passed into the link chain. Since we don't currently allow people to modify the link chain that `MockedProvider` uses, it's safe to assume people won't want this behaviour, as they can't test things like `apollo-link-state` this way. This commit sets a default `resolvers` value of `{}` to enable AC 2.5's new local state handling, and opens the door for passing custom resolvers into the `MockedProvider` via props. Helps fix apollographql/fullstack-tutorial#73.
|
Hey @hwillson, after updating from 2.5.0 to 2.5.1 I am now getting empty responses after I've mocked apollo provider and passed my own resolvers. I am not using apollo-link-state anymore. 2.5.0 version returns proper result but it warns in console that:
Also if I pass null to resolvers in v2.5.1 it also works but still gives the warning. |
|
Interesting - thanks for the head up @Gongreg, I'll take a look. |
|
@Gongreg - Let's track #2825 (comment) in apollographql/apollo-client#4520. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the changes in apollographql/apollo-client#4499, when
MockedProvideris currently used it doesn't have anyresolversset. This means@clientdirectives are passed into the link chain. Since we don't currently allow people to modify the link chain thatMockedProvideruses, it's safe to assume people won't want this behaviour, as they can't test things likeapollo-link-statethis way. This PR sets a defaultresolversvalue of{}to enable AC 2.5's new local state handling, and opens the door for passing custom resolvers into theMockedProvidervia props.Helps with apollographql/fullstack-tutorial#73.