This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
test-link: add stringification to equality check #3078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evans
force-pushed
the
evans/fix-mock-provider-undefined
branch
from
d5cfbcb
to
05a9b6a
Compare
Currently MockLink hides undefined values in its error message. This means that debugging a mismatched result was difficult and required stepping through the code. There are a couple of possible solutions: * update the error message to include the undefined values * modify the `isEquals` comparison of variables to check equality of the stringified value This chooses the latter, since the 99% path for receiving values from a remote source requires serializing variables before using them.
evans
force-pushed
the
evans/fix-mock-provider-undefined
branch
from
05a9b6a
to
42c1425
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently MockLink hides undefined values in its error message. This
means that debugging a mismatched result was difficult and required
stepping through the code.
There are a couple of possible solutions:
isEqualscomparison of variables to check equality of thestringified value
This chooses the latter, since the 99% path for receiving values from a
remote source requires serializing variables before using them.