This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Reorder code to avoid setting state on unmounted component #3139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves the problem of the component being unmounted as a result of onSubscriptionData, then setState causing a React warning. See #2681.
hwillson
approved these changes
Jun 21, 2019
There was a problem hiding this comment.
Thanks for this @jasonpaulos! Normally I'd say we need a test here so we don't regress on this in the future, but we're handling this a bit differently in RA 3 (and check mount status first) so let's go ahead and get this included in the final RA 2 release.
hwillson
added a commit
that referenced
this pull request
Jun 21, 2019
This will make sure `onSubscriptionData` has access to the most up to date subscription result. Relates to #3139.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the problem of the Subscription component being unmounted as a result of
onSubscriptionData, then setState causing a React warning. See #2681 for a complete description of the issue.