This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Conditionally use AC's ObservableQuery.resetQueryStoreErrors
#3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix issue #3090, the `ObservableQuery.resetQueryStoreErrors` method was introduced in `apollo-client` 2.6.3. While `apollo-client` 2.6.3 is a peer dep of the latest version of `react-apollo` (2.5.7), people who can't update their version of `apollo-client` to >= 2.6.3 are running into issues when updating to the latest version of `react-apollo`, since `ObservableQuery.resetQueryStoreErrors` isn't available to them. Since we can't enforce the version of `apollo-client` people are using, this commit adjusts the `Query` component to only use `resetQueryStoreErrors` if it's available. If it isn't, it will call into the `ObservableQuery`'s private API to do the same things as `resetQueryStoreErrors`. This is a hack, but it is temporary as `react-apollo` is launching soon, and will enforce a minimum `apollo-client` version of 2.6.3 (so this workaround won't be needed). Fixes #3148.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix issue #3090, the
ObservableQuery.resetQueryStoreErrorsmethod was introduced inapollo-client2.6.3. Whileapollo-client2.6.3 is a peer dep of the latest version ofreact-apollo(2.5.7), people who can't update their version ofapollo-clientto >= 2.6.3 are running into issues when updating to the latest version ofreact-apollo, sinceObservableQuery.resetQueryStoreErrorsisn't available to them. Since we can't enforce the version ofapollo-clientpeople are using, this commit adjusts theQuerycomponent to only useresetQueryStoreErrorsif it's available. If it isn't, it will call into theObservableQuery's private API to do the same things asresetQueryStoreErrors. This is a hack, but it is temporary asreact-apollois launching soon, and will enforce a minimumapollo-clientversion of 2.6.3 (so this workaround won't be needed).Fixes #3148.