Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

MockNetworkInterface match mock requests regardless of variable order #973

Merged
merged 2 commits into from
Aug 13, 2017
Merged

Conversation

L1fescape
Copy link
Contributor

@L1fescape L1fescape commented Aug 11, 2017

Currently mock data needs to exactly match the request being made within a component being tested. This is because requests object are stringified and used as keys when registering and looking up the corresponding response objects to be returned. This change sorts the request object when it is stringified so the order of variables doesn't matter.

This issue is discussed in #674

@apollo-cla
Copy link

@L1fescape: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@mention-bot
Copy link

@L1fescape, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jbaxleyiii, @calebmer and @mmissey to be potential reviewers.

@jbaxleyiii
Copy link
Contributor

@L1fescape thank you! This looks great to me!

@jbaxleyiii jbaxleyiii merged commit 7308d20 into apollographql:master Aug 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants