Rework build process to use TypeScript source files #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think #152 is a better way to solve apollographql/apollo-client#8688, which was one of the reasons I started working on this PR (hoping that After my investigation yesterday, I remembered why I didn't use TypeScript when I first set this package up: the freedom to hand-craft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a package that advertises better TypeScript support than the package it wraps, it's strange that
zen-observable-tsdoesn't actually use TypeScript internally as a build tool.Instead of hand-crafting
index.d.ts, we should just lettscdo its thing, so this repository looks more like our other TypeScript-friendly projects.