WIP: Fix map function returning undefined.

[dahjelle]

What's the preferred kind of test case for this, where a map function unintentionally returned undefined? I added one, but it seems…strange.

TODO:

• Update CHANGELOG.md with your change
• Make sure all of the significant new logic is covered by tests
• Rebase your changes on master so that they can be merged easily
• Make sure all tests and linter rules pass

[stubailo]

I think that's a pretty reasonable test! You have a typescript error in your code, I think you can avoid it by using square brackets ['TodoList5']['__typename'] instead of the dot notation.

I'd suggest running the tests locally with npm test before opening a PR.

Thanks for finding this bug!

[dahjelle]

@stubailo

I'd suggest running the tests locally with npm test before opening a PR.

Thanks. I wasn't paying enough attention—sorry 'bout that!

Should be updated & ready to go!

[stubailo]

This branch is out-of-date with the base branch

Hmm, I wonder how this happened - maybe you didn't pull all of the changes before merging/rebasing?

[dahjelle]

I think #396 landed between my rebase and my push. Rebased again.

[stubailo]

Wow it's pretty silly. I guess github protected branches can be pretty annoying, but so far it seems to help more than it hurts...

[stubailo]

Thanks a lot for doing this and putting up with the process!

[dahjelle]

👍