Merge pull request containerd#3618 from apostasie/fix-leaking-test

Fix test leaking tagged Alpine image
apostasie · Oct 30, 2024 · acbec64 · acbec64
2 parents ed86d37 + 708f172
commit acbec64
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/cmd/nerdctl/builder/builder_builder_test.go b/cmd/nerdctl/builder/builder_builder_test.go
@@ -86,6 +86,7 @@ CMD ["echo", "nerdctl-builder-debug-test-string"]`, testutil.CommonImage)
 			},
 			{
 				Description: "WithPull",
+				NoParallel:  true,
 				Setup: func(data test.Data, helpers test.Helpers) {
 					// FIXME: this test should be rewritten to dynamically retrieve the ids, and use images
 					// available on all platforms
@@ -106,6 +107,9 @@ CMD ["echo", "nerdctl-builder-debug-test-string"]`, testutil.CommonImage)
 					data.Set("oldImageSha", oldImageSha)
 					data.Set("newImageSha", newImageSha)
 				},
+				Cleanup: func(data test.Data, helpers test.Helpers) {
+					helpers.Anyhow("rmi", testutil.AlpineImage)
+				},
 				SubTests: []*test.Case{
 					{
 						Description: "pull false",