Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es_grad.py parallelisation with ray #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

es_grad.py parallelisation with ray #2

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 17, 2020

Hello Alois,

This PR uses ray in es_grad.py to evaluate and update in parallel the actors.
It results in a great speed-up (almost x num_rl_actors).
To use it, you just need to pip install ray in your python environment first.

From my tests, I observed an unchanged performance however note that I had to update first the critic before updating the actors to enable parallelization which is a small deviation compared to your version.

Hope it'll help :)

@apourchot
Copy link
Owner

Hi Thomas, seems great, thank you ! I think it would be best to add those modifications in a new file, so as to keep the old behavior used in the paper intact. Could you perhaps create a new "es_grad_parallel", or something similar ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants