Add CPU_LIMIT and OAUTH_PROXY_CPU_LIMIT #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I set them to be the same as the requests, because gabi doesn't appear
to be CPU-bound. I checked one cluster's usage via PromQL:
```promql
max_over_time(pod:container_cpu_usage:sum{pod=~"gabi.*"}[24h:5m])
```
and saw 0.02 as the highest number across the last couple of weeks of
metrics, so I figure setting the same as the request seems a reasonable
default.
|
Can one of the admins verify this patch? |
|
related to #65 |
|
covered by #69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I set them to be the same as the requests, because gabi doesn't appear to be CPU-bound. I checked one cluster's usage via PromQL:
and saw 0.02 as the highest number across the last couple of weeks of metrics, so I figure setting the same as the request seems a reasonable default.