This repository has been archived by the owner on Aug 14, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Add assets loading, binary selection and VCS information in manifest #13
Merged
Commits on Feb 26, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 835e5f2 - Browse repository at this point
Copy the full SHA 835e5f2View commit details -
Allow specifying which binary to put into ACI
Add --use-binary option which allows user to choose which binary should be placed in the image if go get builds multiple binaries. This change also introduces some changes in naming - when project example.com/foo/bar has binaries bar and quux, then for quux the created image will have a filename bar-quux.aci, name in manifest will be example.com/foo/bar-quux.
Configuration menu - View commit details
-
Copy full SHA for 19f485a - Browse repository at this point
Copy the full SHA 19f485aView commit details -
Add --asset option which takes two paths separated with OS specific path separator (colon on Unices, semicolon on Windows). The first path specifies a path inside produced image, second part - the path from local filesystem which will be copied into image. We handle only regular files, directories and symlinks that does not point outside the asset.
Configuration menu - View commit details
-
Copy full SHA for d6a542a - Browse repository at this point
Copy the full SHA d6a542aView commit details -
Allow preserving temporary directory
This is strictly developer option to be able to view the contents of /tmp/goaciXXX directory, when something goes wrong.
Configuration menu - View commit details
-
Copy full SHA for 578979c - Browse repository at this point
Copy the full SHA 578979cView commit details -
Add VCS specific label to manifest
It supports getting information from git, hg, svn and bzr.
Configuration menu - View commit details
-
Copy full SHA for 51d508a - Browse repository at this point
Copy the full SHA 51d508aView commit details -
Move asset code into separate file
The goaci.go already looks like a kitchen sink with two year old leftovers. Let's clean it up a bit.
Configuration menu - View commit details
-
Copy full SHA for 9f9d591 - Browse repository at this point
Copy the full SHA 9f9d591View commit details -
Preserve absolute symlink targets
If a symlink target is an absolute path still pointing somewhere inside the asset it sits in then preserve the absoluteness even in rootfs. That requires a bit of path munging.
Configuration menu - View commit details
-
Copy full SHA for 897d6c3 - Browse repository at this point
Copy the full SHA 897d6c3View commit details -
Add two placeholders - GOPATH and PROJPATH. GOPATH placeholder is obvious. PROJPATH placeholder will be replaced with absolute path to project go get is building. Usage is simple: --asset /assets:<PROJPATH>/assets
Configuration menu - View commit details
-
Copy full SHA for 3c49b94 - Browse repository at this point
Copy the full SHA 3c49b94View commit details -
Split out some code to separate functions with hopefully self-explanatory names. The additional aim is to have function fit into single screen.
Configuration menu - View commit details
-
Copy full SHA for fcbabce - Browse repository at this point
Copy the full SHA fcbabceView commit details -
Put misc functions in separate file
Remove some more clutter from goaci.go.
Configuration menu - View commit details
-
Copy full SHA for 2ccaf9b - Browse repository at this point
Copy the full SHA 2ccaf9bView commit details -
More reliable project option parsing
We are using flag package for option parsing, so stop using os.Args. We can take the project from flag.Args after ensuring that it has one and only one string.
Configuration menu - View commit details
-
Copy full SHA for fa54476 - Browse repository at this point
Copy the full SHA fa54476View commit details -
This basically rewrites goaci.go into many smaller and clearer functions. It also removes all uses of die function, so the deferred removal of /tmp/goaciXXX is actually executed (die used os.Exit() which prevented that).
Configuration menu - View commit details
-
Copy full SHA for 4c2f499 - Browse repository at this point
Copy the full SHA 4c2f499View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28b9f0a - Browse repository at this point
Copy the full SHA 28b9f0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9dd4763 - Browse repository at this point
Copy the full SHA 9dd4763View commit details
Commits on Mar 13, 2015
-
Lift restrictions for symlinks in assets
That simplifies the code a lot for a short while. Later some of it will probably come back when we implement checking for dangling symlinks after assets are copied.
Configuration menu - View commit details
-
Copy full SHA for b7a5848 - Browse repository at this point
Copy the full SHA b7a5848View commit details -
These usually are filenames, so it's good to delimit them with quotes in case there are spaces in them.
Configuration menu - View commit details
-
Copy full SHA for 3c5741d - Browse repository at this point
Copy the full SHA 3c5741dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a0af7d - Browse repository at this point
Copy the full SHA 1a0af7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b378df3 - Browse repository at this point
Copy the full SHA b378df3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7f50b3 - Browse repository at this point
Copy the full SHA f7f50b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4143688 - Browse repository at this point
Copy the full SHA 4143688View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f5782c - Browse repository at this point
Copy the full SHA 1f5782cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.