fix: Return null if no simulated location has been previously set (#663)

appium · Feb 20, 2023 · 6a5c48b · 6a5c48b
1 parent 309bfc1
commit 6a5c48b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/WebDriverAgentLib/Categories/XCUIDevice+FBHelpers.h b/WebDriverAgentLib/Categories/XCUIDevice+FBHelpers.h
@@ -174,7 +174,8 @@ typedef NS_ENUM(NSUInteger, FBUIInterfaceAppearance) {
  Only works since Xcode 14.3/iOS 16.4
 
  @param error If there is an error, upon return contains an NSError object that describes the problem.
- @return The current simulated location or nil in case of failure
+ @return The current simulated location or nil in case of failure or if no location has previously been seet
+ (the returned error will be nil in the latter case)
  */
 - (nullable CLLocation *)fb_getSimulatedLocation:(NSError **)error;
 

diff --git a/WebDriverAgentLib/Commands/FBCustomCommands.m b/WebDriverAgentLib/Commands/FBCustomCommands.m
@@ -503,14 +503,14 @@ + (NSString *)timeZone
 {
   NSError *error;
   CLLocation *location = [XCUIDevice.sharedDevice fb_getSimulatedLocation:&error];
-  if (nil == location) {
+  if (nil != error) {
     return FBResponseWithStatus([FBCommandStatus unknownErrorWithMessage:error.description
                                                                traceback:nil]);
   }
   return FBResponseWithObject(@{
-    @"latitude": @(location.coordinate.latitude),
-    @"longiture": @(location.coordinate.longitude),
-    @"altitude": @(location.altitude),
+    @"latitude": location ? @(location.coordinate.latitude) : NSNull.null,
+    @"longitude": location ? @(location.coordinate.longitude) : NSNull.null,
+    @"altitude": location ? @(location.altitude) : NSNull.null,
   });
 }