fix: Add arm64 arch to XctestrunFile path search for simulator #838
Conversation
|
|
| return isTvOS(deviceInfo.platformName) | ||
| ? `WebDriverAgentRunner_tvOS_appletv${deviceInfo.isRealDevice ? `os${version}-arm64` : `simulator${version}-x86_64`}.xctestrun` |
There was a problem hiding this comment.
Perhaps you could use:
`simulator${version}-${os.arch() === "arm64" ? "arm64" : "x86_64"}`
instead of check both cases.
The simulator depends on the host, thus this line can guess the proper naming with the host's architecture.
There was a problem hiding this comment.
I agree. The WDA architecture should be selected based on the current host architecture
There was a problem hiding this comment.
I see we can check the arch by os.arch(), thank you for letting me know about it. I'll fix it.
There was a problem hiding this comment.
By the way, where can I get the os variable? And if it contains the string directly, we may use it like
`simulator${version}-${os.arch()"}`
I checked the DeviceInfo but it doesn't contain the property.
And I also noticed I should change the comment here based on the fix.
https://github.com/appium/WebDriverAgent/blob/master/lib/utils.js#L160-L184
There was a problem hiding this comment.
KazuCocoa
changed the title
KazuCocoa
changed the title
|
appium-webdriveragent v5.15.8 has the fix #840 |
#837
Fixed to check both x86_64 and arm 64 if the device is a simulator.
I added an argument to
getXctestrunFileNamefunction but is has a default value, so it doesn't change the original behavior without it.