Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Make unit tests execution a part of Gradle build lifecycle #1853

Conversation

valfirst
Copy link
Collaborator

@valfirst valfirst commented Jan 31, 2023

Change list

This change simplifies unit tests task management and execution:

  • test task of type Test is created automatically
  • in comparison with previous approach no need to invoke extra task (it was unitTest): whenever build task is run, test task will be executed (this happens because test task is attached to the check lifecycle task)

More details: https://docs.gradle.org/current/userguide/java_testing.html#sec:java_testing_basics

Also now:

  • JitPack build is failed if unit tests fail: no reason to publish invalid build
  • Successful run of unit tests is a mandatory prerequisite for execution of integration Android and iOS tests

Types of changes

What types of changes are you proposing/introducing to Java client?

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@valfirst valfirst force-pushed the make-unit-test-execution-a-part-of-gradle-build-lifecycle branch from 5ff07b3 to d70a5a6 Compare January 31, 2023 23:48
@valfirst valfirst force-pushed the make-unit-test-execution-a-part-of-gradle-build-lifecycle branch from d70a5a6 to 2f43da5 Compare February 1, 2023 06:35
@valfirst valfirst merged commit dc5a97d into appium:master Feb 2, 2023
@valfirst valfirst deleted the make-unit-test-execution-a-part-of-gradle-build-lifecycle branch February 2, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants