Add meaningful error messages to IPP Everywhere PPD generator (Issue #…

…4954)

CHANGES.txt

@@ -15,6 +15,8 @@ CHANGES IN CUPS V2.2.3
 	  supported by the printer (Issue #4953)
 	- IPP Everywhere print queues did not always support all media types
 	  supported by the printer (Issue #4953)
+	- The IPP Everywhere PPD generator did not return useful error messages
+	  (Issue #4954)
 	- Fixed some localization issues on macOS (<rdar://problem/27245567>)
 
 

cups/ppd-cache.c

@@ -3147,15 +3147,27 @@ _ppdCreateFromIPP(char   *buffer,	/* I - Filename buffer */
   if (buffer)
     *buffer = '\0';
 
-  if (!buffer || bufsize < 1 || !response)
+  if (!buffer || bufsize < 1)
+  {
+    _cupsSetError(IPP_STATUS_ERROR_INTERNAL, strerror(EINVAL), 0);
     return (NULL);
+  }
+
+  if (!response)
+  {
+    _cupsSetError(IPP_STATUS_ERROR_INTERNAL, _("No IPP attributes."), 1);
+    return (NULL);
+  }
 
  /*
   * Open a temporary file for the PPD...
   */
 
   if ((fp = cupsTempFile2(buffer, (int)bufsize)) == NULL)
+  {
+    _cupsSetError(IPP_STATUS_ERROR_INTERNAL, strerror(errno), 0);
     return (NULL);
+  }
 
  /*
   * Standard stuff for PPD file...
@@ -4081,6 +4093,8 @@ _ppdCreateFromIPP(char   *buffer,	/* I - Filename buffer */
   unlink(buffer);
   *buffer = '\0';
 
+  _cupsSetError(IPP_STATUS_ERROR_INTERNAL, _("Printer does not support required IPP attributes or document formats."), 1);
+
   return (NULL);
 }