Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename current build directory #3098

Closed
mpilman opened this issue May 7, 2020 · 1 comment · Fixed by #10337
Closed

Rename current build directory #3098

mpilman opened this issue May 7, 2020 · 1 comment · Fixed by #10337
Assignees
Milestone

Comments

@mpilman
Copy link
Contributor

mpilman commented May 7, 2020

#1534 is trying to resolve part of this - but this is not the correct solution for the problem.

Many tools/IDEs (and users) are building in $SOURCE_DIR/build. This is almost a standard way of building cmake projects.

So this directory should not exist. We should therefore rename our build directory so that we don't break the workflow of users and tools who do this. Another reason why this is bad is that there's a risk that someone could accidentally add a file to build that will then be overwritten by cmake.

After build was renamed we can add the whole build directory to .gitignore.

@mpilman mpilman added this to the 7.0 milestone May 7, 2020
@PierreZ
Copy link
Contributor

PierreZ commented Jul 13, 2021

Now that #5162 is merged, we can:

  • add the whole build directory to .gitignore,
  • update README.md.

@AlvinMooreSr are you working on it? This seems like an easy PR for new contributors like me 😄

jzhou77 added a commit to jzhou77/foundationdb that referenced this issue May 24, 2023
xis19 pushed a commit to xis19/foundationdb that referenced this issue May 26, 2023
xis19 pushed a commit to xis19/foundationdb that referenced this issue Jun 1, 2023
xis19 pushed a commit to xis19/foundationdb that referenced this issue Jun 15, 2023
xis19 pushed a commit to xis19/foundationdb that referenced this issue Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants