Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tool versions to Version Catalog #211

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

sgammon
Copy link
Contributor

@sgammon sgammon commented Feb 20, 2024

Summary

Add a fix to make Version Catalog symbols visible within the buildSrc plugins, and then move tool versions (Google Java Format and ktfmt) into the catalog.

Originally previewed as part of #204.

Changelog

  • fix: make version catalog accessible from buildSrc plugins
  • chore: declare googleFormatVersion in version catalog
  • chore: declare ktfmt in version catalog

- fix: make version catalog accessible from `buildSrc` plugins
- chore: declare `googleFormatVersion` in version catalog
- chore: declare `ktfmt` in version catalog

Relates-To: apple#204
Signed-off-by: Sam Gammon <[email protected]>
Copy link
Contributor

@holzensp holzensp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated. CI green after manual restart (session timed out for the last run)

@holzensp holzensp merged commit ca31185 into apple:main Feb 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants